Skip to content

mcp: adds resources and prompts for func subcommands#2890

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
KapilSareen:mcp-08
Jul 8, 2025
Merged

mcp: adds resources and prompts for func subcommands#2890
knative-prow[bot] merged 1 commit intoknative:mainfrom
KapilSareen:mcp-08

Conversation

@KapilSareen
Copy link
Contributor

@KapilSareen KapilSareen commented Jun 25, 2025

Changes

This PR adds resources and prompts of the func subcommands help for the LLM context

Related Epic #2806

@knative-prow knative-prow bot added the do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. label Jun 25, 2025
@knative-prow knative-prow bot requested review from dsimansk and vyasgun June 25, 2025 22:12
@knative-prow knative-prow bot added size/M 🤖 PR changes 30-99 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Jun 25, 2025
@knative-prow
Copy link

knative-prow bot commented Jun 25, 2025

Hi @KapilSareen. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.

Project coverage is 59.38%. Comparing base (d47949c) to head (6cf6c42).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
pkg/mcp/mcp.go 0.00% 88 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2890      +/-   ##
==========================================
- Coverage   60.72%   59.38%   -1.35%     
==========================================
  Files         129      130       +1     
  Lines       15843    16490     +647     
==========================================
+ Hits         9621     9792     +171     
- Misses       5336     5778     +442     
- Partials      886      920      +34
Flag Coverage Δ
e2e-tests 41.95% <0.00%> (+6.94%) ⬆️
integration-tests ?
unit-tests 47.67% <0.00%> (-1.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland lkingland added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels Jun 29, 2025
@lkingland
Copy link
Member

lkingland commented Jul 4, 2025

I really like this dynamic way of defining the prompts and resources.

I understand there may be some spotty support in Clients right now, despite it being part of the MCP spec.

If we can get it to work, great. If not, we may need to do it the long/hard way (for now) and create a separate one for each command. Perhaps that can be automated.

@knative-prow knative-prow bot added size/L 🤖 PR changes 100-499 lines, ignoring generated files. and removed size/M 🤖 PR changes 30-99 lines, ignoring generated files. labels Jul 4, 2025
@KapilSareen KapilSareen marked this pull request as ready for review July 4, 2025 19:08
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. label Jul 4, 2025
@KapilSareen
mcp: adds resources and prompts for func subcommands
6cf6c42 
Signed-off-by: kapil <kapilsareen584@gmail.com>
@knative-prow knative-prow bot added size/M 🤖 PR changes 30-99 lines, ignoring generated files. and removed size/L 🤖 PR changes 100-499 lines, ignoring generated files. labels Jul 7, 2025
@knative-prow knative-prow bot added the lgtm 🤖 PR is ready to be merged. label Jul 8, 2025
@knative-prow
Copy link

knative-prow bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KapilSareen, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
@knative-prow knative-prow bot merged commit 630064c into knative:main Jul 8, 2025
46 of 47 checks passed
@KapilSareen KapilSareen deleted the mcp-08 branch July 8, 2025 12:21
matejvasek pushed a commit to openshift-knative/kn-plugin-func that referenced this pull request Oct 6, 2025
@KapilSareen @matejvasek
mcp: adds resources and prompts for func subcommands (knative#2890)
4375d7c 
Signed-off-by: kapil <kapilsareen584@gmail.com>
matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Oct 6, 2025
@matejvasek @KapilSareen
[release-v1.17] pick mcp (#1368)
b709f7f 
* mcp: adds func mcp command (knative#2836)

Signed-off-by: KapilSareen <kapilsareen584@gmail.com>

* mcp: adds create and deploy tools (knative#2859)

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: adds list tool (knative#2861)

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: adds build tool (knative#2865)

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: adds resource provider and prompt for root cmd docs (knative#2875)

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: adds delete tool and adds remote flag to deploy tool (knative#2863)

* rebases

* adds remote flag to deploy tool

Signed-off-by: kapil <kapilsareen584@gmail.com>

---------

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: extends flags support for existing tools (knative#2889)

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: adds resources and prompts for func subcommands (knative#2890)

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: adds tool and resource for config volumes (knative#2925)

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: refactors pkg for easy maintainability (knative#2928)

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: adds labels and envs config tools and resources (knative#2931)

Signed-off-by: kapil <kapilsareen584@gmail.com>

* mcp: adds remote template support (knative#2951)

Signed-off-by: kapil <kapilsareen584@gmail.com>

---------

Signed-off-by: KapilSareen <kapilsareen584@gmail.com>
Signed-off-by: kapil <kapilsareen584@gmail.com>
Co-authored-by: Kapil Sareen <kapilsareen584@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkingland lkingland lkingland approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

@vyasgun vyasgun Awaiting requested review from vyasgun

Assignees

@lkingland lkingland

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/M 🤖 PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KapilSareen @lkingland